Merged
Conversation
…e_82520, app/code_82B90
…0, app/code_B3A70, app/code_B5280
… app/code_C9B60, app/code_CB7C0, app/level_objects, app/code_D2D50, app/code_D3810
queueRAM
approved these changes
Feb 26, 2026
|
|
||
| // .data | ||
| // list of model ids | ||
| s32 D_8034E810[] = { 0xF4, 0xF5, 0xF6 }; |
Contributor
There was a problem hiding this comment.
0xF4 is the model ID for the giant orange ball. maybe F5 and F6 are the blue and green ones? this file also has references to balls so would fit. don't need to rename in this PR, just wanted to note to remember
| ~0x2C, | ||
| 0x2D, | ||
| 0x87, | ||
| ~0x86, |
Contributor
There was a problem hiding this comment.
given the other values, maybe these are negative -45, 45, 135, -135
just guessing, but maybe angles in degrees
Owner
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already opening this PR so others are aware of this work, will keep it in draft until I've mapped .data as far as I can.